[Iceberg]Support s3 as warehouse directory for hive file catalog#24328
Closed
hantangwangd wants to merge 2 commits intoprestodb:masterfrom
Closed
[Iceberg]Support s3 as warehouse directory for hive file catalog#24328hantangwangd wants to merge 2 commits intoprestodb:masterfrom
hantangwangd wants to merge 2 commits intoprestodb:masterfrom
Conversation
steveburnett
requested changes
Jan 7, 2025
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the doc! Nit in the link formatting, everything else looks good.
| Otherwise, it will be ignored. | ||
| ======================================================= ============================================================= ============ | ||
|
|
||
| Configure the `Amazon S3 <https://prestodb.io/docs/current/connector/hive.html##amazon-s3-configuration>`_ |
Contributor
There was a problem hiding this comment.
Suggested change
| Configure the `Amazon S3 <https://prestodb.io/docs/current/connector/hive.html##amazon-s3-configuration>`_ | |
| Configure the `Amazon S3 <https://prestodb.io/docs/current/connector/hive.html#amazon-s3-configuration>`_ |
Link breaks because of ##.
Member
Author
68edb1a to
9728632
Compare
steveburnett
previously approved these changes
Jan 9, 2025
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, looks good. Thank you!
9728632 to
5718f9b
Compare
Member
Author
|
Close as #24660 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enable iceberg connector to use S3 location as warehouse dir for Hive file catalog.
By configuring the s3 properties described in https://prestodb.io/docs/current/connector/hive.html#amazon-s3-configuration, we can specify a S3 location as the warehouse dir of Hive file catalog. This way, both metadata and data
of iceberg tables will be maintained on S3 storage.
An example configuration includes:
Motivation and Context
Support specifying a S3 location directly as warehouse dir for Iceberg with Hive file catalog
Impact
N/A
Test Plan
OzoneandMinIO)IcebergDistributedTestBaseon S3 storage provided by dockerized MinIOContributor checklist
Release Notes